fix: JoinRoom 비밀번호 검증 조건 및 응답 형식 개선#31
Merged
Sean-mn merged 7 commits intorefactor/claudefrom Apr 1, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes API responses using CommonApiResponse, refactors room DTOs by replacing RoomSummary with GetRoomResponse, and adds unit tests for private room access. Key issues identified include a regression in UserRepository.CreateAsync where the removal of the SQL Upsert logic will lead to primary key violations, and a weakening of password validation in JoinRoomService which should continue to check for whitespace or empty strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚작업 내용
JoinRoomService비밀번호 검증 조건을request.Password != null에서room.IsPrivate기준으로 수정 (공개 방에 비밀번호 전달 시 잘못된 검증 실행되던 버그 수정)CommonApiResponse로 통일CommonApiResponse로 통일RoomSummary레코드 제거 —GetRoomResponse로 대체하여 중복 타입 제거UserRepository.CreateAsync를 Raw SQL에서 EF CoreAddAsync로 교체Room엔터티 최대 플레이어 수를DefaultMaxPlayers상수로 추출비밀번호 검증 버그: 기존 로직은 요청에 비밀번호가 포함된 경우에만 검증을 수행해 공개 방에도 비밀번호를 전달하면 검증이 실행되는 문제가 있었습니다.
room.IsPrivate기준으로 변경하여 비공개 방에서만 검증이 동작하도록 수정했습니다.✅체크리스트